Add logical range partitioning representation#22777
Open
gene-bordegaray wants to merge 1 commit into
Open
Conversation
gene-bordegaray
changed the title
github-actions
Bot
added
logical-expr
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
gene-bordegaray
changed the title
Contributor
Author
|
cc: @gabotechs @stuhood |
stuhood
approved these changes
Jun 5, 2026
Comment on lines
+1268
to
+1270
| return not_impl_err!( | ||
| "Physical plan does not support Range repartitioning" | ||
| ); |
Contributor
There was a problem hiding this comment.
This is a TODO, right? Should it point at a ticket?
Contributor
Author
There was a problem hiding this comment.
yes good catch I can add the epic: #22395
Contributor
Author
There was a problem hiding this comment.
I created small issues for each not impl. They are not very great descriptions but for tracking for now
gene-bordegaray
force-pushed
the
gene.bordegaray/2026/06/logical-source-partitioning
branch
from
7f0949d to
d3907a8
Compare
gabotechs
approved these changes
Jun 8, 2026
Contributor
There was a problem hiding this comment.
Just left some non blocking comments. Pretty straight forward PR! thanks @gene-bordegaray and @stuhood.
Comment on lines
+1268
to
+1274
| // TODO: Support planning LogicalPlan::Repartition with | ||
| // range partitioning. | ||
| // Tracked by https://github.com/apache/datafusion/issues/22786 | ||
| return not_impl_err!( | ||
| "Physical plan does not support Range repartitioning" | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
Don't we have everything we need already for creating this mapping?
LogicalPartitioning::Range(v) => {
let sort_exprs = create_physical_sort_exprs(
v.ordering(),
input_dfschema,
execution_props,
)?;
Partitioning::Range(RangePartitioning::new(
LexOrdering::new(sort_exprs).unwrap(),
v.split_points().to_vec(),
))
Comment on lines
+4550
to
+4553
| .map(ToString::to_string) | ||
| .collect::<Vec<_>>() | ||
| .join(", "); | ||
| let split_points = self |
Contributor
There was a problem hiding this comment.
Using the .join() method from itertools::Itertools should allow you to avoid the Vec allocation:
Suggested change
| .map(ToString::to_string) | |
| .collect::<Vec<_>>() | |
| .join(", "); | |
| let split_points = self | |
| .map(ToString::to_string) | |
| .join(", "); |
| .split_points() | ||
| .iter() | ||
| .map(ToString::to_string) | ||
| .collect::<Vec<_>>() |
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn logical_range_repartition_is_not_supported() -> Result<()> { |
Contributor
There was a problem hiding this comment.
It would be cool if we could make this actually pass in this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Declared scan output partitioning should use logical partitioning metadata, not physical partitioning types. This adds logical range partitioning so range-partitioned sources can declare their layout at the logical layer.
What changes are included in this PR?
Partitioning::RangeandRangePartitioning.SplitPointand shared split-point validation todatafusion-common.Are these changes tested?
Yes. Unit tests added
Are there any user-facing changes?
Yes. This adds public logical range partitioning API. No breaking API changes.